Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538057 --- Comment #2 from Miroslav Suchý <msuchy@xxxxxxxxxx> 2009-12-16 08:07:42 EDT --- > Use %global instead of %define, see done > Use %{_sharedstatedir} instead of %{_var}/lib/, see I'm not willing to use this macro. It eval differently on different systems. E.g in RHEL it eval to /usr/com > Is the license GPLv2 or GPLv2+? Maybe add a doc to clarify? It is GPLv2. Even license text is included in %doc, not sure how you want to clarify it even more. >%{_initrddir} is considered deprecated on Fedora, but still needed on RHEL. done > Add -p to install in order to preserve timestamps of the files, done > Please don't use excessive wildcards like %{_usr}/sbin/* In some previous reviews, somebody else encourages me to use wildcards. So what is correct behaviour? But I do not care :) Done. > you moved %preun before %clean and %files Done > Add more docs, at least an AUTHORS file should IMO be there, Negative. We do not have doc separately for rhnmd, we have documentation for Satellite and when the times come, we can make separate package from it. No intention to put it here due its size. Authors changes a lot. And we (as Spacewalk team) are not willing to maintains such document file. > ChangeLog would be nice too. We have changelog in spec. Guidelines (https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs) do not say anything about separate file. So ... negative. > Please use a more common format for your changelogs. > Bug numbers should be at the end of a changelog entry, e.g. I would not say it is more common (at least outside of Fedora). On fedora-devel-list was discussion on April this year and there was no conclusion about format of changelog (apart from first line). And since our changelog is generated in upstream from commit messages, I can do hardly anything about it, unless I rewrite it or force upstream developers to change their behaviour. :( > BTW: there is a typo: "dependecy" instead of "dependency" fixed > I don't understand dangerous-command-in-%pre: When you migrate settings > from /home/nocpulse, why remove /var/lib/nocpulse/{bin,var}? This doesn't > look related. This for user who had previous version of rhnmd. It was crappy package and when you upgrade this two path will remain on your disk with some dynamicaly created links and files, which were previously not present in %files > I disagree about service-default-enabled, see Well this package is just special wrapper around sshd, and we behave to it similar way as to sshd. And sshd is enabled by default to. Updated SRPM: http://miroslav.suchy.cz/fedora/rhnmd/rhnmd-5.3.5-1.src.rpm Updated SPEC: http://miroslav.suchy.cz/fedora/rhnmd/rhnmd.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review