Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=544745 --- Comment #11 from Arun SAG <sagarun@xxxxxxxxx> 2009-12-12 22:18:27 EDT --- (In reply to comment #10) > I would advice you that next time when you create patches don't merge patches > from another one. It is just a matter of respect someone's time spent to create > a patch. In this case it's Shakthi's time. I won't block the package because of > this. However I feel that Shakthi's contribution deserved to be recognised. :) Agreed :-) . I made a patch out of the updated spice-mode.el file and before patch0 line of SPEC file, i gave credits (as comment) to the authors. is that ok? (In reply to comment #7) > #007: Set gnucap as default (since ngspice is freezing emacs). Remove ngspice > from the Requires and add gnucap as BR I doubt this, do i have to add gnucap as Build requires? what is BR ? gnucap is needed to build the package? May be you meant Requires ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review