Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-dev-tools - Xfce developer tools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209025 ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxxxx 2006-10-03 11:36 EST ------- (In reply to comment #2) > SHOULD Items: > > OK - Should include License or ask upstream to include it. will do. > However, there might be some more Requires. > I see it checking for the following at runtime: > > ## Check for a suitable make added make > ## Check for autoconf, first trying autoconf-2.59, then autoconf-2.58, then libtool already requires autoconf >= 2.50 and Core 5 comes with autoconf-2.59 > ## Check for intltoolize provided by intltool > ## Check for libtoolize provided by libtool > ## Check for glib-gettextize added glib2-devel > ## Check for gtkdocize added gtk-doc > ## Check for aclocal, first trying aclocal-1.9, then aclocal-1.8, and finally already provided by automake > ## Check for autoheader, first trying autoheader-2.59, then autoheader-2.58, already provided by autoconf > ## Check for automake, first trying automake-1.9, then automake-1.8, and finally libtool requires automake >= 1.4, Core 5 comes with 1.9 > > 2. Should require the Xfce package that owns datadir/xfce4... > Should perhaps be xfwm4? (which I need to fix to own that dir). In this case I agree with Patrice, so I made the new package own %dir %{_datadir}/xfce4 New Package: SRPMs at http://home.arcor.de/christoph.wickert/fedora/extras/review/noarch/ SPEC at http://home.arcor.de/christoph.wickert/fedora/extras/review/SPECS/xfce4-dev-tools.spec * Tue Oct 03 2006 Christoph Wickert <fedora christoph-wickert de> - 4.3.99.1-2 - Some more requires: glib2-devel, make and gtk-doc. - Own %%{_datadir}/xfce4 (In reply to comment #3) > It seems to me that the m4 macros should also be in > /usr/share/aclocal > such that it is possible to simply use autoreconf and the > like. I think most macros should already be in there now, but when I run xdt-autogen I still see: Please add the files codeset.m4 gettext.m4 glibc21.m4 iconv.m4 isc-posix.m4 lcmessage.m4 progtest.m4 from the /usr/share/aclocal directory to your autoconf macro directory or directly to your aclocal.m4 file. Any idea where to get the missing files from? glib21.m4 looks like a version/naming problem to me. The current glib2-devel-2.10.3 on Core 5 only provides glib-2.0.m4. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review