Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542518 Hans Ulrich Niedermann <rhbugs@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(itamar@ispbrasil. | |com.br) --- Comment #1 from Hans Ulrich Niedermann <rhbugs@xxxxxxxxxxxxxxxx> 2009-12-11 14:11:37 EDT --- MUST: ok rpmlint clean ok name ok %{name}.spec ok packaging guidelines ok GPLv2 is ok ok License field ok COPYING in %doc ok spec in AmEnglish ok spec legible(*) ok 8bf5e66351156356f3ad07454123affa usbview-1.1.tar.gz ok compiles and builds http://koji.fedoraproject.org/koji/taskinfo?taskID=1870195 NA no excludearch ok BuildReqs are OK, proven by koji build NA no locale stuff (broken PACKAGE_LOCALE_DIR definition is unused) NA no libs installed ok no system lib copies NA not relocatable ok dir ownerships ok files listed only once ok file perms ok %clean ok consistent RPM macro usage ok contains code NA no large doc files ok %doc files not required for runtime NA no header files NA no static libs NA no .pc files NA no lib files NA no devel subpackage NA no .la files FAIL GUI app package must include %{name].desktop file ok no owning other packages' stuff ok %install removes buildroot ok all filenames are valid utf8 SHOULD: NA license text included NA no non-English languages ok package builds in koji ergo mock ok koji scratch build says all arches build OK ok works for me (on F11) NA no scriptlets NA no subpackages NA no .pc files NA no special dependencies (*) You could remove the commented out second "make ... install" line from usbview.spec. Summary: NEEDSWORK mandatory change: Add a usbview.desktop file (if you need a package to model that after, my nted package has passed review with a Fedora specific .desktop file) optional, but recommended change: remove the commented out "make install" line -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review