[Bug 539983] Review Request: qjson - qt-based library that maps JSON data to QVariant object

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=539983





--- Comment #14 from Eli Wapniarski <eli@xxxxxxxxxxxxxxxxxxxx>  2009-12-11 02:21:57 EDT ---
(In reply to comment #13)
> Please change BR: qt to BR-qt-devel. Otherwise the package won't even build in
> mock, which means it won't build in koji.
> 
> Moreover, I made a scratch build in koji with the above BR corrected. You can
> download the RPM's that are generated. We still have rpmlints:
>    qjson-devel.x86_64: W: summary-not-capitalized qjson Development Files
> 
>       This can be fixed easily.


Done

>    qjson-devel.x86_64: W: spurious-executable-perm
> /usr/share/doc/qjson-devel-0.6.3/html/installdox
>    qjson-devel.x86_64: W: doc-file-dependency
> /usr/share/doc/qjson-devel-0.6.3/html/installdox /usr/bin/perl
> 

Please see links below and comments regarding blank doxygen html directory:

http://fedoraproject.org/wiki/MinGW/Rpmlint
https://bugzilla.redhat.com/show_bug.cgi?id=467397#c4

The above warning doesn't seem to be of concern to Fedora. The warning is
produced because I'm building the doxygen docs during rpmbuild and an
installdox script is placed in the html folder on that build.

>       The documentation is still blank. I see this line in the build.log:

Finally clued into this one. Sorry about the misunderstanding. Indeed in the
source contained in the SRPM the html folder is indeed blank. However, if you
were to examine the SPEC file on line 42 you would see that I build the doxygen
during the build process. Which produces the rpmlint warning you mentioned
above. Also, the doxygen docs are then successfully installed in the devel
package on line 77. So if you were to look in the built devel package, you
would see that the doxygen docs are built and in the correct location.

> 
>       Error: file `/builddir/build/BUILD/qjson/doc/' not found
>
>       Perhaps this will help you finding the problem.

If you were to look in both the qjson and qjson-devel package all the
documentation specified in the installation goes to the location expected.

> Again, I urge you to build packages on mock. It will make your life easier.  

Did that with the same results.

SPEC URL: http://orbsky.homelinux.org/packages/qjson.spec
SRPM URL: http://orbsky.homelinux.org/packages/qjson-0.6.3-6.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]