Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226101 --- Comment #4 from Karel Klíč <kklic@xxxxxxxxxx> 2009-12-09 14:10:21 EDT --- [YES] source files match upstream: 613d7cfa23b70c0abae3fabb0a72ff5f lm_sensors-3.1.1.tar.bz2 [YES] package meets naming and versioning guidelines (lm_sensors has an exception that it can use underscore in its name) [YES] specfile is properly named [YES] specfile is cleanly written [NO] specfile uses macros consistently: %{SOURCEx} should probably be %{sourcex}, "Buildroot:" -> "BuildRoot:" [YES] dist tag is present [YES] build root is correct [YES] license field matches the actual license [YES] license is open source-compatible [YES] license text included in package [YES] latest version is being packaged [YES] BuildRequires are proper [YES] compiler flags are appropriate [YES] %clean is present [YES] package builds in mock [YES] debuginfo package looks complete [NO] rpmlint is silent $ rpmlint *.rpm lm_sensors.i686: W: dangerous-command-in-%pre mv lm_sensors.i686: W: dangerous-command-in-%trigger mv lm_sensors.i686: W: dangerous-command-in-%trigger mv lm_sensors.i686: W: one-line-command-in-%trigger /usr/bin/sysconfig-lm_sensors-convert lm_sensors-libs.i686: W: summary-not-capitalized lm_sensors core libraries lm_sensors-libs.i686: W: shared-lib-calls-exit /usr/lib/libsensors.so.4.2.0 exit@xxxxxxxxx lm_sensors-libs.i686: W: no-documentation lm_sensors-libs.i686: E: library-without-ldconfig-postin /usr/lib/libsensors.so.4.2.0 lm_sensors-libs.i686: E: library-without-ldconfig-postun /usr/lib/libsensors.so.4.2.0 lm_sensors-sensord.i686: E: incoherent-subsys /etc/rc.d/init.d/sensord lm_sensors lm_sensors-sensord.i686: W: incoherent-init-script-name sensord ('lm_sensors-sensord', 'lm_sensors-sensordd') 6 packages and 0 specfiles checked; 3 errors, 8 warnings. Imho the following lines should be added to the spec file: %post libs -p /sbin/ldconfig %postun libs -p /sbin/ldconfig [YES] final provides and requires look sane [???] Please consider using "Requires: dmidecode" instead of "Requires: /usr/sbin/dmidecode" [OK] %check is not present [YES] no shared libraries are added to the regular linker search paths in app package [YES] owns the directories it creates (no dirs) [YES] doesn't own any directories it shouldn't [YES] no duplicates in %files [YES] file permissions are appropriate [???] %defattr(-,root,root,-) should be used instead of %defattr(-,root,root) [YES] scriptlets ok [YES] code, not content [YES] documentation is small, so no -docs subpackage is necessary [YES] %docs are not necessary for the proper functioning of the package [YES] no headers [YES] no pkgconfig files [YES] no libtool .la droppings [YES] not a GUI app -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review