Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ivman - Generic handler for HAL events https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208737 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-10-03 01:11 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (QPL/GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 031c763d6acc927bf2fefd7c6140247d ivman-0.6.12.tar.bz2 031c763d6acc927bf2fefd7c6140247d ivman-0.6.12.tar.bz2.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: - Should include License or ask upstream to include it. - Should build in mock. Issues: 1. rpmlint says: W: ivman incoherent-subsys /etc/rc.d/init.d/ivman $servicename W: ivman incoherent-subsys /etc/rc.d/init.d/ivman $servicename W: ivman incoherent-subsys /etc/rc.d/init.d/ivman $servicename I think this is rpmlint getting confused. The pid file looks correct to me. You might doublecheck it. 2. I take it this is targeted for fc6? dbus-glib-devel doesn't exist in fc5. Everything else looks good... this package is APPROVED. Don't forget to close this NEXTRELEASE once it's been imported and built. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review