Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=541664 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-12-09 01:06:38 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1863816 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) 1d833844267dfbb01880b7e0112e325e6ae992b1 Test-Pod-1.40.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=12, Tests=22, 1 wallclock secs ( 0.05 usr 0.01 sys + 0.56 cusr 0.06 csys = 0.68 CPU) + Package perl-Test-Pod-1.40-1.fc13.noarch => Provides: perl(Test::Pod) = 1.40 perl(Test::Pod::_parser) Requires: perl >= 0:5.008 perl(File::Spec) perl(Test::Builder) perl(base) perl(strict) + Not a GUI application Should: 1) Correct license is "GPLv2 or Artistic 2.0" APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review