Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508316 --- Comment #8 from Shakthi Kannan <shakthimaan@xxxxxxxxx> 2009-12-08 09:37:39 EDT --- Created an attachment (id=376915) --> (https://bugzilla.redhat.com/attachment.cgi?id=376915) Fixes free variable reference warnings #01 Shouldn't the pkgname start with capital 'E'macs ? I see it is being used in the Name and in turn in Source0 as well, where the source tarball name starts with emacs-jabber-. https://fedoraproject.org/wiki/Packaging:Emacs#Template_for_a_add-on_package_for_GNU_Emacs_only #02 Attached is a patch to fix the 'free reference to variables' warnings. #03 We can use (declare-function foo) to stop the 'function X might not be defined at runtime' warning, but, declare-function is only available from Emacs 23. Otherwise, we can ignore the warning if you want to use with from Emacs 22. #04 Retain time stamp with 'cp -p', instead of using 'mv' in %install cp -p $RPM_BUILD_ROOT%{emacs_lispdir}/*.el* \ $RPM_BUILD_ROOT%{emacs_lispdir}/%{pkg}/ #05 Cosmetic change, use %{buildroot} instead of $RPM_BUILD_ROOT? I have tested this package and it works. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review