Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545046 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #1 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-12-08 05:53:38 EDT --- A few notes: - you should have a comment about the necessity of the patch in the spec file, for example # Make install target libdir multilib compatible Patch0: cvector-1.0.3-libdir.patch I'm not sure why you change the libtool commands. Can you please clarify what is the intent of adding --tag=CC? - Please fix the tabbing of the subpackages in the spec file. - You have misspelled "vector" as "vecrot" in the %description of -devel. - Send the Makefile patch upstream. The makefile also lacks DESTDIR support, which should be included. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review