Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543549 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #5 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-12-07 10:18:59 EDT --- For -2: (In reply to comment #4) > (In reply to comment #3) > > * Requires > > - Please add the needed rubygem related dependency. > > Note that I don't know if this dependency is optional or not. > > 3. lib/haml/filters.rb: this depends on rubygem-RedCloth for Textile filter, > but Markdown and Maruku filters doesn't have packaged dependencies in fedora > (afaict). The code in filters.rb can handle it though, and these filters are > not a requirement to use haml. What do you suggest ? - It seems filters related dependency is optional, so I don't think adding "R: rubygem(RedCloth)" is strictly needed. > 4. Rakefile has many dependencies (tlsmail, yard, rcov/rcovtask, ruby-prof, > "git" command...) and i'm not sure how useful it is. The only thing i'd like to > keep is the 'test' task. - We usually don't add dependency for Rakefile based dependency ( By the way I like to create -doc subpackage for rubygem based rpm and I usually put Rakefile to -doc, not to main package ) > > * %check > > - Whether adding executable permission to a script or not should > > be determined (for this case) by checking if the script has > > shebang or not, and should not be determined by hardcoded file list. > > Not all files from *_test.rb have shebang (Though i could create a patch for > this and ask upstream to integrate it) - But with your current rpm only ruby script with shebang have executable permission (and not all *_test.rb have shebang) anyway, so judging by my method should be possible. ( By the way if scripts without shebang have executable permission, or if scripts with shebang don't have exectable permission, rpmlint warns about this ). The reason I am talking about this is that I think hardcoding %test_files list should be avoided unless impossible. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review