Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545045 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #1 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2009-12-07 09:49:27 EDT --- Some comments: * Wrt. this construct: %ifarch x86_64 ppc64 sed -e '/^LIB/s/lib/lib64/g' -i Makefile %endif - Such sed calls can be generalized by applying %{_lib} (expands to "lib" on 32bit and to "lib64" on 64bit targets) - Such sed calls are equivalent to "configuring" a package. They belong into %build * static libs %files devel ... %{_libdir}/*.a Feel strongly encouraged not to ship static libs. If you really can't avoid shipping them, move the *.a's to a separate *-static package. * Upstream's tarball name is CQRlib. Fedora convention is to keep upstream's package name => Your package should be named "CQRlib", not cqrlib. * Your patch adds changes the shared libs from --shared to --export-dynamic and removes --release - Why? This is a significant behavioral change to upstream, I don't see any sense in. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review