Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=544821 --- Comment #2 from Felix Kaechele <felix@xxxxxxxxxx> 2009-12-06 12:43:41 EDT --- Fresh review from FUDCon Toronto Room A: [+] source files match upstream: [felix@delta SPECS]$ sha256sum php-gettext-1.0.9.tar.gz ../SOURCES/php-gettext-1.0.9.tar.gz b3aac9dd13971cabd2474cc93abfc665752f1f732646f4c911928b4323a70319 php-gettext-1.0.9.tar.gz b3aac9dd13971cabd2474cc93abfc665752f1f732646f4c911928b4323a70319 ../SOURCES/php-gettext-1.0.9.tar.gz [+] package meets naming and versioning guidelines. [+] spec is properly named, cleanly written, and uses macros consistently. [+] dist tag is present. [+] build root is correct. [+] license field matches the actual license. [+] license is open source-compatible. [+] license text included in package. [+] latest version is being packaged. [NA] BuildRequires are proper. [NA] compiler flags are appropriate. [+] %clean is present. [+] package builds in mock. [+] package installs properly. [NA] debuginfo package looks complete. [+] rpmlint is silent. [+] final provides and requires are sane [NA] %check is present and all tests pass: [+] no shared libraries are added to the regular linker search paths. [+] owns the directories it creates. [+] doesn't own any directories it shouldn't. [+] no duplicates in %files. [+] file permissions are appropriate. [NA] scriptlets match those on ScriptletSnippets page. [+] code, not content. [+] documentation is small, so no -docs subpackage is necessary. [+] %docs are not necessary for the proper functioning of the package. [+] no headers. [+] no pkgconfig files. [NA] no libtool .la droppings. [NA] desktop files valid and installed properly. APPROVED! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review