Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502556 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-review+ --- Comment #6 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-12-05 15:41:57 EDT --- Review: Good: - License ok, but you should query upstream to add headers in .py files - %files section ok - permissions ok - BR/R ok - contains permissable content - contains %check section - name 'pre' is not in the guidelines examples, but I consider this as completely ok - noarch - no locales to handle - no .la files - no devel needed - macros everywhere - no header files - no pc files - doc package ok - no gui -> no .desktop Needswork: - https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - group is wrong: System Environment/Daemons would fit better - I talked upstream to correct the nasty %prep commands. It's tracked in http://support.lamsonproject.org/tktview/6e717821c1e513ce888252276ef8b6524861d9d0 The author of lamson said, he wants to have a release out later today. __________________________________ These are only minor issues, so I'll approve this now, but only import the next release into cvs... __________________________________ APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review