[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537363


Michael Schwendt <mschwendt@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mschwendt@xxxxxxxxx




--- Comment #1 from Michael Schwendt <mschwendt@xxxxxxxxx>  2009-12-05 15:20:37 EDT ---
Things that make you go hmmm...

> sed -i -e '/ldconfig/d' Makefile.template

And later:

> # Add missing symlinks
> ln -sf liblv2-gui.so.0.0.0 %{buildroot}%{_libdir}/liblv2-gui.so.0
> ln -sf liblv2-gui.so.0.0.0 %{buildroot}%{_libdir}/liblv2-gui.so
> ln -sf liblv2-plugin.so.0.0.0 %{buildroot}%{_libdir}/liblv2-plugin.so.0
> ln -sf liblv2-plugin.so.0.0.0 %{buildroot}%{_libdir}/liblv2-plugin.so
> ln -sf libpaq.so.0.0.0 %{buildroot}%{_libdir}/libpaq.so.0

:)

Actually, that's why the Makefile ran "ldconfig -n" in libdir to create the
symlinks for the shared libpaq. With ldconfig, it would reduce to

/sbin/ldconfig -n %{buildroot}%{_libdir}
ln -sf liblv2-gui.so.0.0.0 %{buildroot}%{_libdir}/liblv2-gui.so
ln -sf liblv2-plugin.so.0.0.0 %{buildroot}%{_libdir}/liblv2-plugin.so

at the end of %install. The two "ln -s" are left only because those two shared
libs are built manually in the spec file.

[...]

Upstream is funny so to say:

http://ll-plugins.nongnu.org/dox/lv2-c++-tools/1.0.2/

| These libraries are only available as static libraries (and most
| of the code is template classes in header files), thus ABI stability
| is not an issue. The API will be stable between major version bumps,
| at which the pkg-config name would change to prevent plugins from
| building against an incompatible version, but if you were to modify
| the build system to create shared libraries and link against those
| you are on your own.

Translates to ''I don't really want this API to be used by any C++
application'' as all library updates will require app rebuilds, and API changes
will require additional updates in build frameworks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]