Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=544540 --- Comment #2 from Andrea Musuruane <musuruan@xxxxxxxxx> 2009-12-05 10:51:57 EDT --- (In reply to comment #1) Thanks for your review Dominic! > Issues found: > * You're using $RPM_BUILD_ROOT in line 51 and line 67, but %{buildroot} in > line 60 and 61. This affects required consistency of used macros. I updated the SPEC file accordingly. > * The program is translated into several languages, it would be nice if there > also would be Summarys and descriptions for those languages provided by the > program Unluckily I have no ways to provide a translation for such fields in the SPEC file because upstream do not provide them and I'm not a polyglot. Anyway I added the Italian translations for Summary and Description. Of course other languages are welcome :) > Once the macro-consistency issue is fixed I will approve this package. > Everything > else looks good. Very nice work Andrea! Thanks! http://musuruan.fedorapeople.org/genesis.spec http://musuruan.fedorapeople.org/genesis-0.4.2.1-2.fc12.src.rpm Changelog: - More consistent macro usage - Added Italian summary and description -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review