Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=541535 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@xxxxxxxxx --- Comment #1 from Michael Schwendt <mschwendt@xxxxxxxxx> 2009-12-05 09:29:03 EDT --- > rpmlint is silent. Okay, lemme add some noise then. ;) > # There are some MIT files but the effective license is GPLv2+ > License: GPLv2+ The comment is confusing. What files do you refer to? In case any source files applied a license other than GPLv2+, the guidelines would want you to make that clear. http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Mixed_Source_Licensing_Scenario All of the source files contain a GPLv2+ header, though. Only some autotools' scripts/files contain other headers, but we don't give them special treatment with regard to the licensing guidelines. > raul-gcc44.patch > ... > +#include <stdio.h> In C++ the proper header is <cstdio> though. > %check > pushd tests > export LD_PRELOAD=../src/.libs/lib%{name}.so IMO, better would be this set-up: export LD_LIBRARY_PATH=${RPM_BUILD_ROOT}%{_libdir} > rpm -i /home/qa/tmp/rpm/RPMS/raul-devel-0.5.1-1.fc12.i686.rpm \ > /home/qa/tmp/rpm/RPMS/raul-0.5.1-1.fc12.i686.rpm > error: Failed dependencies: > liblo-devel is needed by raul-devel-0.5.1-1.fc12.i686 Uh, it requires another -devel package that wasn't needed for building it. > $ rpm -qR raul-devel|grep devel > boost-devel > glib2-devel > jack-audio-connection-kit-devel > liblo-devel > $ pkg-config --cflags raul > -pthread -I/usr/include/glibmm-2.4 -I/usr/lib/glibmm-2.4/include > -I/usr/include/sigc++-2.0 -I/usr/lib/sigc++-2.0/include > -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include > $ pkg-config --libs raul > -pthread -lraul -lglibmm-2.4 -lgobject-2.0 -lsigc-2.0 -lgthread-2.0 > -lglib-2.0 -ljack -lpthread -lrt "Requires: glibmm24-devel libsigc++20-devel" is missing in raul-devel. Only because the pkg-config file adds them explicitly. Upstream might add proper "Requires" to raul.pc.in, in particular since some of these explicitly added libraries are not needed when building with libraul. > $ grep mm include/raul/* > AtomRDF.hpp:#include <redlandmm/Node.hpp> > AtomRDF.hpp:#include <redlandmm/World.hpp> > Command.hpp:#include <raul/Semaphore.hpp> > Command.hpp:#include <boost/utility.hpp> > Stateful.hpp:#include <redlandmm/Model.hpp> $ sudo repoquery --whatprovides /usr/include\*/redlandmm/Node.hpp $ Not in Fedora yet. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review