Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543566 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@xxxxxxxxx --- Comment #2 from Michael Schwendt <mschwendt@xxxxxxxxx> 2009-12-05 07:31:48 EDT --- * Please run "rpmlint" on the src.rpm and the built rpms and either resolve any problems it reports or comment on why they need not be fixed. (!) This is explicitly left to you as an exercise. Feel free to ask any questions that might come up, though. * You could also submit a scratch-build in the official Fedora build system, which is explained at: https://fedoraproject.org/wiki/PackageMaintainers/Join * Why the need for glibc-static? https://fedoraproject.org/wiki/Packaging:Guidelines#Staticly_Linking_Executables > Release: 2.beta5%{?dist} This doesn't adhere to the Package Naming Guidelines for pre-releases: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages > Summary: Library to allow transparent SOCKS proxying > Group: Applications/Internet Perhaps nit-picky, but what is it, a library or an application? ;-) > %description > ...the internet. ... the Internet. > %doc %{_mandir}/man?/* The %doc here is redundant. Files in %_mandir are implicitly marked as %doc. > %files There are a couple of documentation files included in the tarball, which look like worthy additions for the %doc line: FAQ ChangeLog > %post > /sbin/ldconfig > %postun > /sbin/ldconfig This creates shell-scripts within /sbin/ldconfig is executed via /bin/sh. The more common form is to run /sbin/ldconfig directly by using the -p argument (to specify what to run instead of /bin/sh): %post -p /sbin/ldconfig %postun -p /sbin/ldconfig > * Thu Dec 3 2009 Jean-Francois Saucier <jfsaucier@xxxxxxxxxxxx> - > 1.8-2.beta5.fc12 Widely accepted practise is to omit the .fc12 expanded dist value here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review