[Bug 543685] Package review: libnes - Driver library for libibverbs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543685





--- Comment #1 from Michael Schwendt <mschwendt@xxxxxxxxx>  2009-12-05 07:05:08 EDT ---
> %makeinstall

Avoid this macro unless normal  "make DESTDIR=${RPM_BUILD_ROOT} install"  (with
an optional INSTALL="install -p" doesn't work. Add a comment if you really need
this macro. The way %makeinstall overrides variables to insert the buildroot
path bears risks and has lead to problems before.


> %{_sysconfdir}/libibverbs.d/*.driver

"repoquery --whatprovides /etc/libibverbs.d" on Fedora 12 returns nothing,
which means it's an unowned directory. Most likely in package "libibverbs".


> %package static
> Summary: Static version of the libnes driver
> Group: System Environment/Libraries

Rather "Development/Libraries".


> Provides: %{name}-devel = %{version}-%{release}
...
> %files static
> %defattr(-,root,root,-)
> %{_libdir}/*.a

A static library without any headers? Isn't this package missing a dependency
on some -devel package that would define the API for this lib? Same question
applies to the virtual -devel package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]