Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543608 --- Comment #8 from David Zeuthen <davidz@xxxxxxxxxx> 2009-12-04 08:44:46 EDT --- Hey, thanks for reviewing this (In reply to comment #5) > Packaging guidelines: the guidelines nowadays contain language that forbids > explicit dependencies for stuff thats already pulled in via library > dependencies. So the Requires for dbus, I'm going to keep this one because we really need the bus daemon running - and it's not impossible (in fact it would be desirable) that libdbus.so could be packaged separately from the bus daemon. > dbus-glib, glib2, polkit, parted, Removed. > udev, We need the udev daemon - libudev and libgudev are packaged separately. > libatasmart We need the specified minimal version for certain bug-fixes. > It might be nice to have a /usr/libexec/udisks/ instead of dumping all the > helpers into /usr/libexec, but thats not a must-fix. All files are prefixed with udisks- anyway. We might want to just use $libdir/udisks instead to avoid this though. I'll consider this upstream. (FWIW, I'd rather see Fedora just pass --libexecdir=$libdir/$package_name just like Debian and SUSE does.) > Upstream sources: need upstream location Fixed (see TODO) > # TODO: should be fixed upstream > > Is it ? Not yet. I believe this is a bug with install(1) since the file has mode 0644 in the git repo - I need to investigate further. Here are the changes I've made: --- udisks.spec.prev 2009-12-04 08:26:12.000000000 -0500 +++ udisks.spec 2009-12-04 08:41:43.000000000 -0500 @@ -17,7 +17,8 @@ License: GPLv2+ Group: System Environment/Libraries URL: http://www.freedesktop.org/wiki/Software/udisks -Source0: %{name}-%{version}.git20091202.tar.gz +# TODO: when fd.o #22578 is resolved, update URL to proper location +Source0: http://hal.freedesktop.org/releases/%{name}-%{version}.git20091202.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root BuildRequires: glib2-devel >= %{glib2_version} BuildRequires: dbus-devel >= %{dbus_version} @@ -30,14 +31,13 @@ BuildRequires: libgudev1-devel >= %{udev_version} BuildRequires: libudev-devel >= %{udev_version} BuildRequires: sg3_utils-devel >= %{sg3_utils_version} +# needed to pull in the system bus daemon Requires: dbus >= %{dbus_version} -Requires: dbus-glib >= %{dbus_glib_version} -Requires: glib2 >= %{glib2_version} -Requires: polkit >= %{polkit_version} -Requires: parted >= %{parted_version} +# needed to pull in the udev daemon Requires: udev >= %{udev_version} -Requires: mdadm >= %{mdadm_version} +# we need at least this version for bugfixes / features etc. Requires: libatasmart >= %{libatasmart_version} +Requires: mdadm >= %{mdadm_version} # for smp_rep_manufacturer Requires: smp_utils >= %{smp_utils_version} # for mount, umount, mkswap @@ -50,8 +50,7 @@ Requires: dosfstools # for mlabel Requires: mtools -# for mkntfs -# no ntfsprogs on ppc, though +# for mkntfs - no ntfsprogs on ppc, though %ifnarch ppc ppc64 Requires: ntfsprogs %endif -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review