Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539983 --- Comment #5 from Eli Wapniarski <eli@xxxxxxxxxxxxxxxxxxxx> 2009-12-04 03:17:05 EDT --- Sorry about the delay in getting this looked after. I have had an extremely distracting couple of weeks. (In reply to comment #4) > (In reply to comment #2) > When you are running "%{cmake} ..", you can add the flag > "-DQJSON_BUILD_TESTS=1" so the tests are built. i.e. > %{cmake} .. -DQJSON_BUILD_TESTS=1 > > Then in the %check section you will execute these tests. Something like > %check > LD_PRELOAD=%{_target_platform}/%{_lib}/libqjson.so > %{_target_platform}/tests/testparser > LD_PRELOAD=%{_target_platform}/%{_lib}/libqjson.so > %{_target_platform}/tests/testserializer Done > Add BR: doxygen. Then in the doc/ directory, just run > doxygen > It will create an html/ direcory inside doc/ add this directory to the %doc of > the devel subpackage. Done. This should probably go in the base package shouldn't it? Its documentation not header files and I would assume that the docs contains how to use. > a directory. This package puts a file inside %{_includedir}/qjson/ but this > directory is not owned by any package! You must own this directory with the > devel subpackage. So replace the line > %{_includedir}/qjson/*.h > with either > %{_includedir}/qjson/ > or > %dir %{_includedir}/qjson > %{_includedir}/qjson/*.h > so that the directory is owned. I hope you got the idea. This must be satisfied > by any package in Fedora. Done > > - Where can I find an example to properly add FindQJSON.cmake as a requirment? > > Or better yet and quicker if you could detail the correct line. > > > > I don't know exactly. You might want to do some research. However, I see that > cmake package put a lot of modules into /usr/share/cmake/Modules/ so you might > want to move that file into that directory in %install. Also I believe that > this file must go to the devel package. Note that you will need to require > cmake (for the devel package) for directory ownership. > Cmake was added as Requirment in a the devel package as well and the module was moved over to the devel package. I don't believe that it should be included as a requirment because if it is required and it isn't yet built and installed then I would not be able to build the package. Please correct me if I'm wrong. > %{_libdir}/libfoo.so.* > go to the main library package, whereas the single file, which is a symlink > %{_libdir}/libfoo.so > goes to the devel package. Please fix this in your package accordingly. Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review