Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 --- Comment #8 from Scott Collier <boodle11@xxxxxxxxx> 2009-12-03 21:08:42 EDT --- (In reply to comment #7) > pxe-kexec.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 26) > 3 packages and 0 specfiles checked; 0 errors, 1 warnings. > > Fix this. You don't actually need any indentation on the make line, since the > whole command fits nicely on one line. Fixed. > > > - The changelog is messed up. Fix it. > > - If you updated the version from Ed's 0.1.7 to 0.2.3, you should have reset > the release tag to 1. So the following should be release 2. > Fixed. > > Review: > > MUST: The package does not yet exist in Fedora. The Review Request is not a > duplicate. OK > > MUST: The spec file for the package is legible and macros are used > consistently. NEEDSWORK > - Macro consistency problem. Fixed. > > <snip> > SHOULD: The package builds in mock. OK > > > Fix the spec file before import to CVS. The package has been > > APPROVED Thanks for the review Jussi. Here's the new spec and srpm: Spec URL: http://boodle.fedorapeople.org/RPMS/pxe-kexec.spec SRPM URL: http://boodle.fedorapeople.org/RPMS/pxe-kexec-0.2.3-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review