Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543840 --- Comment #4 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-12-03 17:27:44 EDT --- - You still have the empty Requires: line that has been commented out in the spec. Please remove it. - Normally the %build and %install phases are placed consecutively in the spec file, and the %check phase is somewhere near the end (e.g. before %clean). This is due to the fact that %check is ran after %install. - I'm wondering about the arrangement of the files. I don't think udcli should be in the -devel package. It would make a lot more sense, if udcli was in the main package. (Or a subpackage named udcli, as called by upstream) If the libs are used by other software, too, then one can separate the library into a subpackage. (-libs or libudis86 as called by upstream) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review