Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543425 --- Comment #7 from Robert Scheck <redhat-bugzilla@xxxxxxxxxxxx> 2009-12-03 03:34:32 EDT --- Siddhesh, I had a look to your spec file. A few thoughts and comments: - You are currently mixing $RPM_BUILD_ROOT and %{buildroot}, choose one and please keep it consistent (https://fedoraproject.org/wiki/PackagingGuidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS) - I can't see a reason to have the "Requires:" lines inside of the spec file. If your software links to a library, rpmbuild is catching up the dependency in the end of the build process and adds "Requires:" to the required libs. - Why do you do "%configure --prefix=/usr" rather "%configure"? Is there a real reason for? If you do "rpm --eval '%configure'", you see what %configure will be expanded to. - You want to use parallel make for making your package. If the software does not support it right now, please make a comment and otherwise please use it: https://fedoraproject.org/wiki/PackagingGuidelines#Parallel_make - You might want to preserve timestamps by appending INSTALL="install -p" to the "make install" command. As Ralf agreed with me, it is not required on a technically base, Guidelines just suggest it, see e.g. https://fedoraproject.org/wiki/PackagingGuidelines#Timestamps - As far as I can see, you're missing "BuildRequires: freetype-devel", otherwise I had trouble to rebuild the package - Can you please choose a valid BuildRoot tag from the available list? https://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag - You are missing the pareparation of BuildRoot in %install section, see https://fedoraproject.org/wiki/PackagingGuidelines#Prepping_BuildRoot_For_.25install - I'm wondering about the following lines in your spec file: %dir %{_datadir}/gource/* %dir %{_mandir}/man*/* %dir %{_datadir}/gource/fonts/* Have a look at: https://fedoraproject.org/wiki/Packaging:UnownedDirectories - Can you please communicate with upstream and ensure that your patch really makes it into the next release of gource? Thank you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review