[Bug 543425] Review Request: gource - Software version control visualization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543425





--- Comment #4 from Rakesh Pandit <rpandit@xxxxxxxxxx>  2009-12-03 01:30:24 EDT ---
""
autoreconf
%configure --prefix=/usr
make
""

needs to be replaced with

""
%configure
make %{?_smp_mflags}
""

%configure macro already has --prefix=/usr and other options and a lone make is
not advisable.

moreover timestamp needs to be saved, while copying files into BUILDROOT in
%install section.

I would also suggest to try and get rid of patch for version correction, as
running autoreconf is not advised. If you really care about package version,
try sed in configure script.

Thanks,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]