Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226552 manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |CURRENTRELEASE --- Comment #6 from manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx> 2009-12-02 15:04:46 EDT --- Indeed, most of the issues are solved. However there are 2 cosmetic issues left which would be nice to see fixed (especially the first one): - please either remove the buildroot line completely or use one of the forms accepted by http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag - there are duplicate BuildRequires: pkgconfig (by glib2-devel), automake (by libtool), autoconf (by libtool) Since both issues are purely cosmetic now, I'll leave their fixing to your appreciation. Closing the review as done and fixed. Thank you, Adam. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review