[Bug 541902] Review Request: almanah - Application for keeping an encrypted diary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541902


Simon Wesp <cassmodiah@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




--- Comment #2 from Simon Wesp <cassmodiah@xxxxxxxxxxxxxxxxx>  2009-12-02 13:47:49 EDT ---
OK - MUST: $ rpmlint /var/lib/mock/fedora-12-ppc/result/*
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

OK - MUST: Named according to the Package Naming Guidelines

OK - MUST: Spec file name matches the base package %{name}

OK - MUST: Package meets the Packaging Guidelines

OK - MUST: Fedora approved license and meets the Licensing Guidelines.

OK - MUST: License field in spec file doesn't matches the actual license.

OK - MUST: License files included in %doc

OK - MUST: Spec is in American English

OK - MUST: Spec is legible

OK - MUST: Sources match the upstream source by MD5
cca92b59002fa9e0515287f3df38cb1c

OK - MUST: Successfully compiles and builds into binary rpms on ppc

N/A - MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.

OK - MUST: All build dependencies are listed in BuildRequires.

OK - MUST: Handles locales properly with %find_lang

N/A - MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.

N/A - MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review.

OK - MUST: Owns all directories that it creates

OK - MUST: No duplicate files in the %files listing

OK - MUST: Permissions on files are set properly, includes %defattr(...)

OK - MUST: Package has a %clean section, which contains rm -rf %{buildroot}.

OK - MUST: Consistently uses macros

OK - MUST: Package contains code, or permissable content

N/A - MUST: Large documentation files should go in a -doc subpackage

OK - MUST: Files included as %doc do not affect the runtime of the application

N/A - MUST: Header files must be in a -devel package

N/A - MUST: Static libraries must be in a -static package

N/A - MUST: Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig'.

N/A - MUST: If a package contains library files with a suffix, then library
files that end in .so must go in a -devel package.
Doesn't make sense for this package

N/A - MUST: devel packages must require the base package using a fully
versioned dependency

OK - MUST: The package does not contain any .la libtool archives.

N/A - MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.

OK - MUST: Package does not own files or directories already owned by other
packages.

OK - MUST: At the beginning of %install, the package runs rm -rf %{buildroot}.

OK - MUST: All filenames valid UTF-8


SHOULD Items:
OK - SHOULD: Source package includes license text(s) as a separate file.

N/A - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.

OK - SHOULD: Builds in mock.

OK - SHOULD: Compiles and builds into binary rpms on all supported
architectures.

N/A - SHOULD: Functions as described.

FIX - SHOULD: Scriptlets are used, those scriptlets must be sane.
update icon cache scriplet is missing
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

N/A - SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.

N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg

N/A - SHOULD: If the package has file dependencies outside of /etc, /bin,
/sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the
file instead of the file itself.


Other items:
OK - latest stable version

OK - SourceURL valid

OK - Compiler flags ok

OK - Debuginfo complete



Just some cosmetical things, before you include it in cvs

1.)
%{_datadir}/%{name}
please suggest that this is a directory and attach a / behind NAME

2.)
please try expand your description lines to 80 characters or one word less..


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]