Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225851 Miroslav Lichvar <mlichvar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dnovotny@xxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Miroslav Lichvar <mlichvar@xxxxxxxxxx> 2009-12-02 12:21:56 EDT --- Review follows: OK source files match upstream: cced6d709df6fad3baf8831f027d62d5 gob2-2.0.16.tar.gz BAD source contains full URL - source should point to http://ftp.5z.com/pub/gob/gob2-2.0.16.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. - %makeinstall can be replaced with more correct make install DESTDIR=$RPM_BUILD>_ROOT OK dist tag is present. OK build root is correct. OK license field matches the actual license (GPLv2+). OK license is open source-compatible. License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock. OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review