Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539387 --- Comment #7 from Mario Ceresa <mrceresa@xxxxxxxxx> 2009-12-02 11:07:32 EDT --- Hello Peter! thanks for your comments. * I'm not sure about name. Perhaps 'itk' would be better name than InsightToolkit? Yes, but package itk already exists and is an object oriented extensions to Tk. Maybe I should use libitk? * I just found, that ITK contains numerous bundled libraries, many of them are duplication Fedora's system ones - see 'Utilities' directory. This should be fixed (and necessary BuildRequires should be added). You're right. Shame on me! I'll fix it. * Also I'm anxious about the contents of 'Code/Patented' folder. The Patented code is optional for ITK and is actually disabled by default. However, I'll add the -DITK_USE_PATENTED:BOOL=OFF cmake flag to the specs to be sure that is never included in the packages. Do you want the folder to be erased in the %prep or %build part? I'm a bit busy and can't make all the requested changes right now, but I'll try to address all of your notes and make a new package later this week. BTW I activated my brand new fedora people account (how cool! :) ) and republished there the srpms and specs. http://mrceresa.fedorapeople.org/InsightToolkit.spec http://mrceresa.fedorapeople.org/InsightToolkit-3.16.0-1.fc12.src.rpm Beware that I simply copied there the old ones! I'll post a message when the new version is available. Cheers, Mario -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review