Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542740 --- Comment #2 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-11-30 15:26:45 EDT --- - Move the static library to a -static subpackage (or don't ship it at all - why bother with static libraries?). - You are mixing styles, i.e. $RPM_BUILD_ROOT vs. %{buildroot}, $RPM_OPT_FLAGS vs. %{optflags}. - I think you can safely drop the alpha stuff ("%ifarch axp" and %patch0). Otherwise, add a comment to the spec about the patch. - If you drop the patch, replace make RPM_OPT_FLAGS="$RPM_OPT_FLAGS" MFLAG="$MFLAG" with make CFLAGS="%{optflags}" - Please use %{_bindir}/f2c %{_includedir}/f2c.h instead of using wildcards when referring to single files. Don't mix %{name} and f2c interchangeably in the spec. - Preserve time stamps in %install with "install -p". - Don't use "install -s" which strips the binary. - You don't need to create the installation directories with mkdir -p %{buildroot}%{_libdir} mkdir -p %{buildroot}%{_includedir} mkdir -p %{buildroot}%{_bindir} mkdir -p %{buildroot}/%{_mandir}/man1 if you just use install -D. => e.g. %install rm -rf %{buildroot} install -D -p -m 644 libf2c/libf2c.a %{buildroot}%{_libdir}/libf2c.a install -D -p -m 644 f2c.h %{buildroot}%{_includedir}/f2c.h install -D -p -m 755 src/f2c %{buildroot}%{_bindir}/f2c install -D -p -m 644 src/f2c.1t %{buildroot}/%{_mandir}/man1/f2c.1 install -D -p -m 755 libf2c/libf2c.so.0.22 %{buildroot}%{_libdir}/libf2c.so.0.22 ln -sf libf2c.so.0.22 %{buildroot}%{_libdir}/libf2c.so - I guess you can tidy the changelog by removing the oldest entries that are not versioned. - rpmlint is not clean: f2c.src: W: summary-ended-with-dot The f2c Fortran to C/C++ conversion program and static libraries. f2c.src: W: name-repeated-in-summary f2c f2c.src:12: W: unversioned-explicit-obsoletes f2c-libs f2c.x86_64: W: summary-ended-with-dot The f2c Fortran to C/C++ conversion program and static libraries. f2c.x86_64: W: name-repeated-in-summary f2c f2c.x86_64: W: obsolete-not-provided f2c-libs f2c.x86_64: E: no-ldconfig-symlink /usr/lib64/libf2c.so.0.22 f2c.x86_64: W: shared-lib-calls-exit /usr/lib64/libf2c.so.0.22 exit@xxxxxxxxxxx f2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libf2c.so f2c.x86_64: W: devel-file-in-non-devel-package /usr/include/f2c.h f2c.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libf2c.a 3 packages and 0 specfiles checked; 1 errors, 10 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review