Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542754 --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-11-30 14:15:11 EDT --- Some quick notes: * Unneeded macros - You don't have to define %name, %version macros * Source - Source tarball included in your srpm does not match with what I could download fromt the URL written as Source0: --------------------------------------------------------- 165485 2009-05-17 14:22 artha-0.9.1.tar.gz 165078 2009-11-28 02:13 artha-0.9.1-1.fc11.src/artha-0.9.1.tar.gz --------------------------------------------------------- * License - Should be "GPLv2+" * BuildArch - "i386" is wrong because F-11 uses i586 and F-12 uses i686. And this BuildArch is completely unneeded (because this builds on ix86/x86_64/ppc/ppc64) * BuildRequires - "BR: autoconf, automake, libtool" don't seem to be needed because autotools are not called during build. - Please try to remove redundant BR. For example: * "gtk2-devel" always requires "glib2-devel", so "BR: glib2-devel" is redundant. * Note that "libnotify-devel" requires "glib2-devel" "gtk2-devel" "dbus-glib-devel" so these 3 BRs can be removed, however I don't object to keep writing "BR: gtk2-devel dbus-glib-devel" if you want. * Parallel make - Support parallel make if possible: https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make * Timestamp - Please consider to use --------------------------------------------------- make install DESTDIR=${RPM_BUILD_ROOT} INSTALL="install -p" --------------------------------------------------- to keep timestamps on installed files as much as possible. This method usually works for Makefiles generated by recent autotools. * %defattr - Now we usually use %defattr(-,root,root,-) * Directory ownership issue - The directory %{_datadir}/artha/ itself is not owned by any packages: https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging:UnownedDirectories#Common_Mistakes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review