Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=541589 --- Comment #3 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2009-11-30 07:38:51 EDT --- (In reply to comment #1) > 0.) The -javadoc subpackage should requires jpackage-utils > ...that owns %_javadocdir Fixed. > > 1.) Does not build > you probably meant to add junit4 to the classpath Fixed. > > 2.) You don't use macros consistently > please use either $RPM_BUILD_ROOT or %{buildroot} macro but not both Fixed. > > The rest is just matter of clean style. Just for your considerations, probably > nothing that would block the review: > > You can do this in one shot, without calling rm: > -find -name '*.class' -exec rm -f '{}' \; > -find -name '*.jar' -exec rm -f '{}' \; > +find \( -name '*.class' -o -name '*.jar' \) -delete Fixed. (In reply to comment #2) > 3.) You do not run the test suite > Please do so, ideally in %check section. Seems like you'd need to add a > dependency on hamcrest. Test suite is failing for me and upstream build is a nightmare. I've submitted a few issues about that but no response yet. Hopefully this is not a blocker. > > I'd also suggest replacing Summary with something more descriptive, (i.e. > adding "database library" at the end or something like that). Hmm, I'm not sure I understand what you want. I picked the first paragraph of sqljet.com assuming upstream devs will describe their work best. > > The rest looks well > * Named and versioned in accordance with guidelines > * License ok, license tag correct, license present in package documentation > * spec file clean and legible > * filelist sane New package: Spec URL: http://akurtakov.fedorapeople.org/sqljet.spec SRPM URL: http://akurtakov.fedorapeople.org/sqljet-1.0.1-2.fc12.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1837449 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review