Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=541765 Mary Ellen Foster <mefoster@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mefoster@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mefoster@xxxxxxxxx --- Comment #1 from Mary Ellen Foster <mefoster@xxxxxxxxx> 2009-11-30 06:22:56 EDT --- Summary: a few minor points, and one more major one: - Can you verify that the license really is GPLv2+ and not GPLv2? - It would be helpful to add comments indicating what each of the patches does - The rpmlint output warns on the explicit Require: libgle after the renaming; please verify that it's really needed - Please create a .desktop file for the GUI application - My local build of this package segfaults when I run the NanoEngineer-1 executable. :( Here's the full checklist: [+] MUST: rpmlint must be run on every package. The output should be posted in the review. With the s/gle/libgle/ modification, I get this: NanoEngineer-1.x86_64: E: explicit-lib-dependency libgle This is probably not an issue, as the package doesn't have an automatic dependency on libgle from anything else, but can you confirm that it really does need libgle at runtime? [+] MUST: The package must be named according to the Package Naming Guidelines . [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . [+] MUST: The License field in the package spec file must match the actual license. -- As far as I can tell, the combined package is GPLv2 -- how do you get the +? (I'm prepared to be convinced because of all of the other License files shipped for libraries that it links against) [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [5] [+] MUST: The spec file for the package MUST be legible. [6] [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. -- md5sum Downloads/NanoEngineer-1_Suite_v1.1.1.12.tar.gz rpmbuild/SOURCES/NanoEngineer-1_Suite_v1.1.1.12.tar.gz 65646dc685d14156631d6c31d95b1b56 Downloads/NanoEngineer-1_Suite_v1.1.1.12.tar.gz 65646dc685d14156631d6c31d95b1b56 rpmbuild/SOURCES/NanoEngineer-1_Suite_v1.1.1.12.tar.gz [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [7] [+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. -- Looks good, and it was nice of upstream to create the page you reference. Don't forget to change "gle" to "libgle" [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13] [+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. [14] [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [15] [+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [16] [+] MUST: Each package must consistently use macros. [17] [+] MUST: The package must contain code, or permissable content. [18] [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [19] [-] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [26] [+] MUST: All filenames in rpm packages must be valid UTF-8. [27] [*] SHOULD: The reviewer should test that the package builds in mock. [30] -- Can't test this yet until libgle gets accepted [-] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. I built this package locally on my x86_64, Fedora 12 machine, and here's what happened when I try to run it: starting NanoEngineer-1 in [/home/mef3], Mon Nov 30 11:14:04 2009 using Python: 2.6.2 (r262:71600, Aug 21 2009, 12:23:57) [GCC 4.4.1 20090818 (Red Hat 4.4.1-6)] on path: /usr/bin/python Version: NanoEngineer-1 v1.1.1 (running a GPL distribution) enabling developer features DISABLE_SLOT_ARGCOUNT_RETRY = True samevals.so/dll or Numeric not available, not using SAMEVALS_SPEEDUP made prefs db, basename /home/mef3/Nanorex/Preferences/bsddb-shelf didn't find /home/mef3/Nanorex/Preferences/default_prefs_v1-1-1.txt note: KNOWN_MMPFORMAT_VERSIONS contains more recent versions than the one we're writing by default, '080327 required; 080529 preferred' (saving history in file "/home/mef3/Nanorex/Histories/h20091130-111407.txt") Traceback (most recent call last): File "./main.py", line 142, in <module> File "./main.py", line 137, in _start_NE1 File "/usr/lib64/NanoEngineer-1_0.9.2.app/program/ne1_startup/main_startup.py", line 201, in startup_script foo = MWsemantics() # This does a lot of initialization (in MainWindow.__init__) File "/usr/lib64/NanoEngineer-1_0.9.2.app/program/ne1_ui/MWsemantics.py", line 192, in __init__ self.setupUi() # Ui_MainWindow.setupUi() File "/usr/lib64/NanoEngineer-1_0.9.2.app/program/ne1_ui/Ui_MainWindow.py", line 97, in setupUi self.commandToolbar = CommandToolbar(self) File "/usr/lib64/NanoEngineer-1_0.9.2.app/program/commandToolbar/CommandToolbar.py", line 162, in __init__ self.setupUi() File "/usr/lib64/NanoEngineer-1_0.9.2.app/program/ne1_ui/toolbars/Ui_CommandToolbar.py", line 171, in setupUi self.flyoutToolBar = FlyoutToolBar(self) File "/usr/lib64/NanoEngineer-1_0.9.2.app/program/ne1_ui/toolbars/FlyoutToolbar.py", line 35, in __init__ self._setExtensionButtonIcon() File "/usr/lib64/NanoEngineer-1_0.9.2.app/program/ne1_ui/toolbars/FlyoutToolbar.py", line 71, in _setExtensionButtonIcon extension_button.setIcon(geticon( AttributeError: 'NoneType' object has no attribute 'setIcon' -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review