Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Wx - Interface to the wxWidgets cross-platform GUI toolkit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208009 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-10-01 19:46 EST ------- * source files match upstream: 95689cae67e55eb62febe8f41751c1c2 Wx-0.57.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64n). * package installs properly * debuginfo package looks complete. * rpmlint has only bugus warnings. * final provides and requires are sane: (hilariously huge dependency list snipped) * %check is present but necessarily disabled in mock. I ran the tests manually outside of mock and: All tests successful, 12 subtests skipped. Files=16, Tests=784, 8 wallclock secs ( 3.56 cusr + 0.55 csys = 4.11 CPU) All tests successful. Files=4, Tests=19, 2 wallclock secs ( 0.92 cusr + 0.15 csys = 1.07 CPU) All tests successful. Files=2, Tests=3, 0 wallclock secs ( 0.38 cusr + 0.05 csys = 0.43 CPU) All tests successful. Files=2, Tests=21, 0 wallclock secs ( 0.60 cusr + 0.06 csys = 0.66 CPU) All tests successful. Files=1, Tests=1, 1 wallclock secs ( 0.29 cusr + 0.06 csys = 0.35 CPU) All tests successful. Files=2, Tests=5, 1 wallclock secs ( 0.68 cusr + 0.11 csys = 0.79 CPU) All tests successful. Files=4, Tests=15, 2 wallclock secs ( 1.63 cusr + 0.20 csys = 1.83 CPU) All tests successful. Files=2, Tests=10, 0 wallclock secs ( 0.68 cusr + 0.11 csys = 0.79 CPU) All tests successful. Files=2, Tests=16, 1 wallclock secs ( 0.73 cusr + 0.10 csys = 0.83 CPU) All tests successful. Files=2, Tests=2, 1 wallclock secs ( 0.63 cusr + 0.12 csys = 0.75 CPU) All tests successful. Files=2, Tests=5, 0 wallclock secs ( 0.36 cusr + 0.08 csys = 0.44 CPU) All tests successful. Files=2, Tests=14, 1 wallclock secs ( 0.36 cusr + 0.06 csys = 0.42 CPU) All tests successful. Files=2, Tests=5, 0 wallclock secs ( 0.53 cusr + 0.06 csys = 0.59 CPU) All tests successful. Files=2, Tests=4, 0 wallclock secs ( 0.48 cusr + 0.07 csys = 0.55 CPU) All tests successful. Files=3, Tests=9, 3 wallclock secs ( 1.88 cusr + 0.23 csys = 2.11 CPU) All tests successful. Files=4, Tests=9, 3 wallclock secs ( 1.08 cusr + 0.16 csys = 1.24 CPU) All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.32 cusr + 0.06 csys = 0.38 CPU) All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.34 cusr + 0.06 csys = 0.40 CPU) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers (except the standard arch-specific Perl module headers) * no pkgconfig files. * no libtool .la droppings. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review