Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528469 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2009-11-28 09:32:15 EDT --- REVIEW: + rpmlint is ok php-ezc-EventLogDatabaseTiein.src: I: checking php-ezc-EventLogDatabaseTiein.noarch: I: checking 2 packages and 1 specfiles checked; 0 errors, 0 warnings. + package name ok + spec file name ok + package meet the PHP Guidelines (new update) + License ok : BSD + License is upstream + spec in english and legible + license file in sources is provided + sources match the upstream sources d261edd630fe9741cfc6be0cf3c41f93 EventLogDatabaseTiein-1.0.2.tgz + Source URL ok + build on F12.x86_64 + BuildRequires (php-pear >= 1:1.4.9-1.2, php-channel(components.ez.no)) ok + no locale + no .so + own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + contain code + small documentation not required to run + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + build in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=1835253 + no test suite + scriptlets ok + Final Requires ok /usr/bin/pear php-common >= 5.2.1 php-pear(components.ez.no/Database) >= 1.2 php-pear(components.ez.no/EventLog) >= 1.0.3 + Final Provides ok php-pear(components.ez.no/EventLogDatabaseTiein) = 1.0.2 php-ezc-EventLogDatabaseTiein = 1.0.2-1.fc8 I think you should keep the Requires php-pear(components.ez.no/Base) >= 1.2. If this package is already required, version could be useful for documentation. **** APPROVED **** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review