Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526426 --- Comment #9 from Thomas Fitzsimmons <fitzsim@xxxxxxxxxxx> 2009-11-27 16:18:41 EDT --- I also packaged this independently. I compared our three versions. Here are my suggestions for a combined package. I like gle as a name, but since that's already taken, libgle is fine. The license field is complicated. The closest representation I came up with is: License: GPLv2+ or (Artistic clarified and MIT) where MIT is an approximation of: gle-3.1.0/src/COPYING.src which, as far as I can tell, is an IBM MIT-like license that's not present in Fedora's list: http://fedoraproject.org/wiki/Licensing#SoftwareLicenses URL and Source0 should point to gle's new home: URL: http://linas.org/gle/ Source0: http://linas.org/gle/pub/gle-%{version}.tar.gz Ralf got the minimal set of BuildRequires but since this is a Fedora package, I prefer to reference the actual dependencies directly, rather than use virtual provides: BuildRequires: mesa-libGL-devel BuildRequires: freeglut-devel BuildRequires: libXmu-devel BuildRequires: libXi-devel The guidelines don't mention anything about not referencing virtual provides, so this is a personal preference (the choice between compatibility with other distros and future-proofing wrt to Fedora). I like Ralf's use of --disable-static rather than deleting the .a file after the build. To be explicit I added: Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig but the guidelines don't mention that: https://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries so omitting them is fine. I think Ralf's package is the closest to complete. It only needs the License, URL and Source0 (and possibly BuildRequires) changes. Who wants to be the libgle maintainer for Fedora? I'd prefer not to be; I only packaged GLE because it is a dependency of NanoEngineer-1: https://bugzilla.redhat.com/show_bug.cgi?id=541765 which I do want to maintain. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review