Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540791 --- Comment #4 from Matthew Kent <mkent@xxxxxxxxxxxx> 2009-11-26 22:48:08 EDT --- Thank you for the review. (In reply to comment #2) > Some notes: > > * BuildRequires > - "BR: gcc" is redundant because gcc is always installed > with mockbuild: > https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 > ( Well, I can guess why you added such explicit "BR: gcc" because > actually "rake check" calls gcc while the rebuilt rpm itself > is noarch, however still I think "BR: gcc" is redundant ) > Noted, thank you for the link. > ! example scripts > ------------------------------------------------------- > # Organize this in a more typical way > mkdir %{buildroot}%{geminstdir}/examples > mv %{buildroot}%{geminstdir}/*.rb %{buildroot}%{geminstdir}/examples/ > ------------------------------------------------------- > - I don't object to this, however I am not sure this is > really needed or not, as > * these scripts are packaged into -doc subpackage so people > will easily find that these scripts are examples or so. > * Also $ gem contents --prefix RubyInline expects that these > scripts are under %geminstdir. > This is NOT a blocker, because we already delete or move files > which are expected by $ gem contents, however for this > case I don't strictly feel the necessity for moving these > files. > > However again I don't object to this. You're right - I should leave this up to the upstream developers. Spec URL: http://magoazul.com/wip/SPECS/rubygem-RubyInline.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-RubyInline-3.8.3-3.fc13.src.rpm * Thu Nov 26 2009 Matthew Kent <mkent@xxxxxxxxxxxx> - 3.8.3-3 - Drop redundant BR for gcc (#540791) - Leave examples as upstream intended (#540791) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review