Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515230 --- Comment #6 from David Sommerseth <davids@xxxxxxxxxx> 2009-11-25 10:06:28 EDT --- Thanks again for another review! First of all, I'm sorry for the mix up between the .src.rpm and the .spec file. I'm not sure how that has happened. I'm not in direct control over that web space, so I've posted new versions where I have full control over the files. The community website will be updated again when the review is completed. Spec URL: http://people.redhat.com/~dsommers/python-dmidecode/python-dmidecode.spec SRPM URL: http://people.redhat.com/~dsommers/python-dmidecode/python-dmidecode-3.10.7-2.fc11.src.rpm In regards to the "Requires" section, this contradicts the message in comment #1, where Jason Tibbits says: "rpm finds the delepdency on libxml2.so.2 itself; there's no need to specify it manually." And now, rpmlint do give an error: python-dmidecode.x86_64: E: explicit-lib-dependency libxml2-python I've added it, according to your request, but I am willing to take it away if this is not correct. * Parallel make I've looked into this. As the building is done via python setup.py/Distutil, I don't see any possibility to support parallel building. Therefore, I find it rather misleading adding %{_smp_mflags} to the make command. I hope you don't mind me that I have not modified this. * Macros Fixed! * Directory ownership issue Fixed! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review