Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510195 --- Comment #2 from Andrew Overholt <overholt@xxxxxxxxxx> 2009-11-24 11:04:43 EDT --- Sorry, this somehow slipped off of my to-do list. A few comments: - is this commented-out line okay? BuildRequires: ice-java >= 3.3.1 - you probably don't need to build gcj bits since the rest of the Eclipse SDK doesn't have them - I believe Alex fixed the pdebuild wrapper script to avoid the need for -a "-DjavacSource=1.5 -DjavacTarget=1.5" but it's not harming anything so feel free to leave it - there appears to be a typo in the readme file. I think "Activating the Plugin for a Project" should be on a new line. Otherwise: OK naming good OK file locations fine OK licensing fine OK md5sum matches upstream OK rpmlint fine $ rpmlint eclipse-slice2java-3.3.1-1.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ../RPMS/x86_64/eclipse-slice2java-3.3.1-1.fc12.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. PLEASEFIX please use either %{buildroot} OR $RPM_BUILD_ROOT but not both -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review