[Bug 540328] Review Request: gtkhash - GTK+ utility for computing message digests or checksums

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=540328





--- Comment #1 from Michael Schwendt <mschwendt@xxxxxxxxx>  2009-11-23 08:05:02 EDT ---
> # enable/disable nautilus extension
> %global _with_nautilus 1
>
> %if 0%{?_with_nautilus:1}
> ...
> %endif

The superior conditional build implementation for this package would do this
instead:

  # by default build nautilus extension
  %bcond_without nautilus

  %if %{with nautilus}
  ...
  %endif

And that would give you a "--without nautilus" option for rpmbuild. And if you
ever need to disable the subpackage by default, you would simply replace 
%bcond_without  with  %bcond_with  and no other changes elsewhere. That would
add a "--with nautilus" rpmbuild option.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]