Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494695 --- Comment #16 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-11-23 05:49:57 EDT --- Still not addressed: * %global _miconsdir %{_datadir}/icons/mini There is no such package in Fedora repositories, which owns this directory. Also your package doesn't own it. This should be fixed. I believe, that this icon should be placed in some other directory than %{_datadir}/icons/mini . * The macro %{_iconsdir} is superfluous. %global _iconsdir %{_datadir}/icons %global _hiconsdir %{_datadir}/icons/hicolor Take a look at both places, where you're using %{_iconsdir} - actually, you should use %{_hiconsdir} macro there. I advice you to shorten the number of macro being used. * Directory ownership issues: %{_libdir}/%{name} should be owned by the main package. %{_includedir}/%{name} should be owned by *-devel sub-package * Also consider removing entirely %doc sections from plugin sub-packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review