Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533803 --- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-11-23 05:13:47 EDT --- Fi(In reply to comment #1) > * "Group" tag of base package should be: System Environment/Libraries Fixed. > * Source URL points at a web page instead of the source tarball. Use this (it > follows the guidelines, too): > http://downloads.sourceforge.net/libcue/libcue-%{version}.tar.bz2 Fixed. > > %description > > Libcue is intended to parse a so called [...] > > Correct English IMO would be: Libcue is intended for parsing a so-called [...] Fixed. > > W: shared-lib-calls-exit /usr/lib/libcue.so.1.0.3 exit@xxxxxxxxx > > Not good, since this is a library. Libraries ought to return error values > instead of terminating the process. This exit call is in a fatal error function > inside the generated flex scanner code. I'll sent a message upstream regarding this issue. > * Two source files rem.c and rem.h contain a BSD license header and the name of > the current developer. According to Fedora's Licensing Guidelines, this must be > reflected in the "License" tag plus a comment in the spec file: > > # Files libcue/rem.{c,h} contain a BSD header > License: GPLv2 and BSD Fixed. http://peter.fedorapeople.org/libcue.spec http://peter.fedorapeople.org/libcue-1.3.0-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review