Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-09-30 03:09 EST ------- Well, 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * rpmlint is not silent. W: kdeartwork-extras macro-in-%changelog _libdir W: kdeartwork-extras macro-in-%changelog _libexecdir Use %% to avoild having macros expanded. * Requires: - Does this package (kdeartwork-extras) really require xscreensaver related packages? It is someting like "optional", isn't it? Perhaps there are some users who don't want to install xscreensaver-gl-extras. I also wonder why this package require xscreensaver-base. Perhaps KDE has its own screensaver mechanism isn't it? (I use GNOME and xscreensave as screensaver, so I don't know well about KDE). * BuildRequires: - Is xscreensaver-base really required? 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = Nothing. 3. Other things I have noticed: A. request: * Desktop files corresponding to the following hacks are missing - glschool (in xscreensaver-gl-extras) - topblock (in xscreensaver-gl-extras) Would you add the desktop files for these hacks? * IMO, the hacks in the following package can also be used for this package. rss-glx (in extras and maintained by Nils Philippsen) xdaliclock (in extras and maintained by Chris Ricker) Would you add the corresponding desktop files or ask the maintainers to support this package? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review