Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491497 --- Comment #13 from Christian Krause <chkr@xxxxxxxxxxx> 2009-11-22 10:39:42 EDT --- I've tested the newest package. It looks better, but there are still a couple of problems: 1. The spec file you provided does not match the spec file inside the src.rpm. Please make sure that you also provide a consistent pair of spec file and src.rpm . 2. According to the used directory and file owners ("dmapd") I assume the service should run as the user dmapd. If the daemon is started via /etc/init.d/dmapd, the service runs as root. 3. The ldconfig call in %post is correct, but the second one in %preun is wrong - it must be in %postun. 4. Here is the current rpmlint output: rpmlint RPMS/i686/dmapd-*16* SRPMS/dmapd-0.0.16-1.fc12.src.rpm SPECS/dmapd.spec dmapd.i686: W: conffile-without-noreplace-flag /etc/sysconfig/dmapd dmapd.i686: W: non-standard-uid /var/db/Storage/Movies dmapd dmapd.i686: E: non-standard-dir-perm /var/db/Storage/Movies 0700 dmapd.i686: W: non-standard-uid /var/db/Storage dmapd dmapd.i686: E: non-standard-dir-perm /var/db/Storage 0700 dmapd.i686: W: non-standard-uid /var/run/dmapd dmapd dmapd.i686: E: non-standard-dir-perm /var/run/dmapd 0700 dmapd.i686: W: non-standard-uid /var/cache/dmapd dmapd dmapd.i686: E: non-standard-dir-perm /var/cache/dmapd 0700 dmapd.i686: E: zero-length /usr/share/doc/dmapd-0.0.16/NEWS dmapd.i686: W: non-standard-uid /var/db/Storage/Pictures dmapd dmapd.i686: E: non-standard-dir-perm /var/db/Storage/Pictures 0700 dmapd.i686: W: non-standard-uid /var/db/Storage/Music dmapd dmapd.i686: E: non-standard-dir-perm /var/db/Storage/Music 0700 dmapd.i686: E: postun-without-ldconfig /usr/lib/libdmapd.so.0.0.16 dmapd.i686: W: non-standard-dir-in-var db dmapd-devel.i686: W: no-documentation 4 packages and 1 specfiles checked; 8 errors, 9 warnings. Please fix: dmapd.i686: E: zero-length /usr/share/doc/dmapd-0.0.16/NEWS dmapd.i686: E: postun-without-ldconfig /usr/lib/libdmapd.so.0.0.16 (see 3.) Please comment to: dmapd.i686: W: non-standard-dir-in-var db Especially: What's the purpose of this directory? Could it be probably put somewhere else? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review