Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539837 David Timms <dtimms@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #5 from David Timms <dtimms@xxxxxxxxxxxx> 2009-11-21 22:19:01 EDT --- (In reply to comment #3) > Thanks for the quick review! No probs. > As of an RPM update in Fedora 10 and later, > > * %buildroot is defined by default, > * BuildRoot definition in the spec file is ignored, > * %buildroot tree is removed automatically at beginning of %install, > * a default %clean section is provided by rpmbuild. > > This package actually is my first public one to omit all these items as they > are no longer necessary. OK, that explains why rpmbuild actually succeeds, and the package works. Closest info I found was in bug #455387, but is there a specific reference in wiki / lists that we can point to ? Thanks for explanations / info about the other items. I notice the -0.1, -0.2 package release numbers. It was pointed out to me that these don't meet the packaging standards (because it isn't a beta/prerelease package; I assume you'll import and commit with version -1 ? I notice there is a lot of warnings during the build on i386/f12, but AFAIK we don't expect packagers to resolve those, so I consider this package: Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review