Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540034 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-review+ --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-11-21 20:56:42 EDT --- Review: Good: - sources generated as described: made a diff -r diff -r was not completely empty, some diffs in .svn If you'd have done tar ... --exclude=.svn ... this would be gone. (and a smaler package) - rpmlint ok as described - (version) naming according guidelines - Group ok - buildroot ok - macros everywhere - parallel builds enabled - permissions are ok - %files section is good, bad to look add, because of many %ghost and %config, but no packager fault - BR and R ok - nothing from %doc is required Needswork: - There is a GPLv3 COPYING, but some files contain GPLv2+ headers, other contain nothing at all. So some files are GPLv3 and others are GPLv2+. Probably they want to have anything GPLv2+. But for now, till this issue is resolved, you need to use GPLv3... Approving this, if you change it to GPLv3. ______________________ APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review