Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538303 --- Comment #4 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-11-21 15:19:52 EDT --- (In reply to comment #3) > > * Requires/BuildRequires > > - Would you check if "Requires: rubygem(hoe)" is really needed? > > Seems to be. The Rakefile uses hoe's lib/hoe/test.rb to provide the following > tasks: However - In my opinition, to begin with Rakefile is usually somewhat similar with Makefiles on autotool based tarball. So I usually put Rakefile to -doc subpackage as I don't think people usually need Rakefile. - As you know usually I always request to execute "rake test" in rpmbuild (i.e. executing test should be done by _us_, like "make check"). If the dependency for "rake test" is needed, perhaps we have to add "Requires: rubygem(rake)" (not BuildRequires) for binary gem-based rpm, which I think is not desired. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review