[Bug 536683] Review Request: eclipse-mdt-uml2 - Implementation of the UML2 OMG metamodel for Eclipse

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=536683





--- Comment #1 from Lubomir Rintel <lkundrak@xxxxx>  2009-11-21 13:53:00 EDT ---
Good work, Mat.

* Package name and version are in accordance with packaging guidelines
* SPEC file clean, legible and well-commented
* License tag correct, license packaged as %doc
* Builds fine in mock
http://koji.fedoraproject.org/koji/taskinfo?taskID=1821764
* RPMLint happy (a couple of false positives about spelling errors in fc13)
* Filelist okay
* Provides/Require list ok

A few objections:

1.) Why do you check stuff out from CVS? There seem to be a source/sdk bundle
available at the downloads page:
http://www.eclipse.org/modeling/mdt/downloads/?project=uml2

2.) Please don't pretty-format the Description. It does not always look well in
package management front-ends.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]