Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533744 --- Comment #6 from D Haley <mycae@xxxxxxxxx> 2009-11-20 22:28:42 EDT --- Argh. I wrote all of this, then firefox crashed as I was about to submit it. Anyway here is the condensed version * Please modify setup to use the -c parameter, creating a folder %{name}-%{version}. creating a dir called "source" in BUILD is not desirable. See http://www.rpm.org/max-rpm/s1-rpm-inside-macros.html * I concur that plugins work, isntalled in user dir and in imagej/plugins which is great. * I don't think you need all the rm -fs at the start # erase binary and useless files rm -rf .FBC* rm -rf macros/.FBC* rm macros/build.xml rm -f .gdb_history rm -rf __MACOSX * To make maintenance a bit easier, this can (at your option) be changed from: chmod 755 macros chmod 644 macros/About\ Startup\ Macros chmod 644 macros/*.txt chmod 644 macros/data/*.txt chmod 644 macros/tools/*.txt chmod 755 macros/data chmod 755 macros/tools to: find ./macros -name \*.txt -type f -exec chmod 644 {} \; find ./macros -type d -exec chmod 755 {} \; I'll do a full review on the next version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review