Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491497 Christian Krause <chkr@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo? --- Comment #11 from Christian Krause <chkr@xxxxxxxxxxx> 2009-11-20 17:08:50 EDT --- I've tested the newest package with the libdmapshare package from updates-testing: Please use rpmlint. ;-) It reveals not only minor problems but also major issues: 1. %doc must be inside of a %files section 2. the FAQ file should not be packaged since it doesn't contain anything 3. the package contains a library but doesn't call ldconfig http://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries 4. the source tarball which is available upstream is not the same as the one in the provided src.rpm: d1b81cc2a5f3d4bb76366d12914cfcc9 dmapd-0.0.15.tar.gz (upstream) dc00b094845c758a5e193e4968439de5 SOURCES/dmapd-0.0.15.tar.gz (from src.rpm) 5. dmapd can't be started: /usr/lib/dmapd/0.0.15/modules/libphoto-meta-reader-graphicsmagick.so: cannot open shared object file: No such file or directory ** ERROR **: Error opening /usr/lib/dmapd/0.0.15/modules/libphoto-meta-reader-graphicsmagick.so aborting... Aborted -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review